[wp-trac] [WordPress Trac] #44141: Privacy: Don't replace comment author URL with anything

[WordPress Trac]

#44141: Privacy: Don't replace comment author URL with anything
--------------------------------------+----------------------
 Reporter:  johnbillion               |       Owner:  (none)
     Type:  defect (bug)              |      Status:  new
 Priority:  normal                    |   Milestone:  4.9.7
Component:  Comments                  |     Version:  4.9.6
 Severity:  normal                    |  Resolution:
 Keywords:  has-patch has-unit-tests  |     Focuses:  privacy
--------------------------------------+----------------------

Comment (by birgire):

 [attachment:44141.2.diff] includes some minor suggestions:

 - Uses {{{assertSame()}}} instead of {{{assertEquals()}}}, for stricter
 checks.
 - Changes {{{@since 5.0.0}}} to {{{@since 4.9.6.}}} in
 {{{anonymization.php}}}.
 - Adjusts the {{{test_anonymize_with_filter()}}}, so it removes only the
 filter callback that was added, before the assertions.
 - Adjusts the {{{filter_wp_privacy_anonymize_data()}}} so it also tests
 the {{{$data}}} input argument.
 - Adjusts the inline docblock for
 {{{filter_wp_privacy_anonymize_data()}}}:  adds a {{{@since}}} and adds
 the variable to the {{{@return}}} line.

 ps: I noticed that [attachment:44141.diff] changes the email anonymization
 as well. Should the ticket be adjusted to mention that as well?

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/44141#comment:10>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform