[wp-trac] [WordPress Trac] #44253: @return missing in doc comment of get_admin_page_parent function

WordPress Trac noreply at wordpress.org
Tue May 29 17:24:07 UTC 2018


#44253: @return missing in doc comment of get_admin_page_parent function
------------------------------+-------------------------------
 Reporter:  subrataemfluence  |       Owner:  (none)
     Type:  defect (bug)      |      Status:  new
 Priority:  normal            |   Milestone:  Awaiting Review
Component:  Plugins           |     Version:  trunk
 Severity:  normal            |  Resolution:
 Keywords:  dev-feedback      |     Focuses:  coding-standards
------------------------------+-------------------------------

Comment (by kennithnichol):

 Given PHPs type coercion, this really could just `return $parent_file;`
 without any check for empty, the caller should be responsible for checking
 for empty().

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/44253#comment:2>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list