[wp-trac] [WordPress Trac] #43986: Disable "Install Plugin" button for PHP required version mismatch
WordPress Trac
noreply at wordpress.org
Mon May 28 19:59:02 UTC 2018
#43986: Disable "Install Plugin" button for PHP required version mismatch
-------------------------------------------------+-------------------------
Reporter: schlessera | Owner: (none)
Type: task (blessed) | Status: new
Priority: normal | Milestone: 5.0
Component: Plugins | Version:
Severity: major | Resolution:
Keywords: needs-unit-tests servehappy dev- | Focuses:
feedback has-patch |
-------------------------------------------------+-------------------------
Comment (by afragen):
So @SergeyBiryukov and I decided to create 2 patches, one with a single
line message and one with a two line message. The two line message treats
WordPress compatibility and PHP compatibility as separate concerns.
Both patches should be functionally equivalent.
These examples are obviously from the two line variant.
[[https://core.trac.wordpress.org/attachment/ticket/43986/43986v3-1.diff|43986v3-1.diff]]
[[Image(screenshot_02.4.png)]]
Shows two line in the plugin card.
[[Image(screenshot_03.2.png)]]
Shows separate notices in the 'More Details' iframe.
[[Image(screenshot_04.png)]]
Shows when compatibility exists, no notice is displayed.
For the purposes of these examples I set the {{{$wp_version = '4.7.0';}}}
--
Ticket URL: <https://core.trac.wordpress.org/ticket/43986#comment:35>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list