[wp-trac] [WordPress Trac] #44246: Add `check-node-version` to check required Node.js and npm versions are installed
WordPress Trac
noreply at wordpress.org
Sun May 27 22:37:03 UTC 2018
#44246: Add `check-node-version` to check required Node.js and npm versions are
installed
------------------------------+-----------------------
Reporter: netweb | Owner: azaozz
Type: enhancement | Status: reopened
Priority: normal | Milestone: 5.0
Component: Build/Test Tools | Version:
Severity: normal | Resolution:
Keywords: needs-patch | Focuses:
------------------------------+-----------------------
Comment (by netweb):
Replying to [comment:2 ocean90]:
> You can't use the dev dependency `check-node-version` in `preinstall`
unless it's installed globally.
Good catch, I've added [attachment:44246.2.diff] that moves the task to
`postinstall`, this way the dependancy is installed before the script is
called.
It's not ideal as after updating node/npm removing `node_modules` and
running `npm install` should probably occur, I'll investigate options to
display a notice of some form in a follow up ticket
--
Ticket URL: <https://core.trac.wordpress.org/ticket/44246#comment:5>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list