[wp-trac] [WordPress Trac] #43987: Block plugins from updating if required PHP version is not supported

WordPress Trac noreply at wordpress.org
Fri May 25 08:25:23 UTC 2018


#43987: Block plugins from updating if required PHP version is not supported
---------------------------------------------------+---------------------
 Reporter:  schlessera                             |       Owner:  (none)
     Type:  task (blessed)                         |      Status:  new
 Priority:  normal                                 |   Milestone:  5.0
Component:  Plugins                                |     Version:
 Severity:  normal                                 |  Resolution:
 Keywords:  needs-unit-tests servehappy has-patch  |     Focuses:
---------------------------------------------------+---------------------

Comment (by schlessera):

 @afragen I think some of the naming is awkward, as you refer to the name
 of the plugin meta key `'requires php'`.

 As an example, the method `load_requires_php()` is grammatically weird, as
 it reads differently than it is intended: "something we want to load does
 require PHP" or something...

 I suggest adapting the naming to make the purpose clear, regardless of
 what the index key is called, like `enforce_php_requirement()` or similar.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/43987#comment:7>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list