[wp-trac] [WordPress Trac] #43986: Disable "Install Plugin" button for PHP required version mismatch

[WordPress Trac]

#43986: Disable "Install Plugin" button for PHP required version mismatch
-------------------------------------------------+-------------------------
 Reporter:  schlessera                           |       Owner:  (none)
     Type:  task (blessed)                       |      Status:  new
 Priority:  normal                               |   Milestone:  5.0
Component:  Plugins                              |     Version:
 Severity:  major                                |  Resolution:
 Keywords:  needs-unit-tests servehappy dev-     |     Focuses:
  feedback has-patch                             |
-------------------------------------------------+-------------------------

Comment (by schlessera):

 Some notes regarding the above patches (should apply equally to @afragen's
 & @SergeyBiryukov's patches):

 - You should account for the possibility of `$plugins` not containing the
 `'requires_php'` index, to make the code more robust. If that index is not
 included, just assume it is compatible.
 - Information should not be coded in color or symbols only, because of
 a11y reasons. This applies to things like a pink background just as well
 as the colored symbols. As an example, the color-coded ✔️and ❌should
 contain invisible screen-reader-text so that screen readers can read out
 loud what is happening.

 @SergeyBiryukov I think your logic is off. If the plugin does not contain
 the required headers, the code will default to blocking installations.

 In terms of code, I think we have two different approaches here: action-
 based vs hard-coded. One is more flexible and looks cleaner, the other is
 a better enforcement. I'm not yet sure on which method I'd prefer...

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/43986#comment:29>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform