[wp-trac] [WordPress Trac] #42888: Add a "Show" button next to password fields on mobile

[WordPress Trac]

#42888: Add a "Show" button next to password fields on mobile
-------------------------------------+-------------------------------------
 Reporter:  johnbillion              |       Owner:  Iceable
     Type:  enhancement              |      Status:  assigned
 Priority:  normal                   |   Milestone:  5.0
Component:  Login and Registration   |     Version:
 Severity:  normal                   |  Resolution:
 Keywords:  good-first-bug has-      |     Focuses:  accessibility,
  patch dev-feedback has-            |  javascript
  screenshots has-ux-feedback        |
-------------------------------------+-------------------------------------
Changes (by boemedia):

 * keywords:  good-first-bug has-patch dev-feedback has-screenshots ux-
     feedback => good-first-bug has-patch dev-feedback has-screenshots has-
     ux-feedback


Comment:

 I applied the patch using Grunt. It's my first time, so I may have done
 something wrong. If I tested the wrong way, please forget my comment here
 asap (I'll keep learning ;))

 I used 42888-4.diff by @Iceable. See my short video for visual support.

 I tested in Chrome on a macbook, version 66.0.3359.181.

 - The text show is there, but totally at the right side of the browser
 screen.
 - When I click 'show', the text changes to 'hide', but nothing happens in
 the password field, I still see dots instead of text.

 I suppose the show/hide part was meant to be next to the password field
 instead of al the way to the right. But showing the password to check
 typing is a great improvement from a usability perspective, so I'd love to
 see this implemented.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/42888#comment:18>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform