[wp-trac] [WordPress Trac] #44171: Flushing the rewrite rules is "wrong" on the front-end

WordPress Trac noreply at wordpress.org
Mon May 21 19:28:38 UTC 2018


#44171: Flushing the rewrite rules is "wrong" on the front-end
-------------------------+---------------------
 Reporter:  azaozz       |       Owner:  (none)
     Type:  enhancement  |      Status:  new
 Priority:  normal       |   Milestone:  5.0
Component:  General      |     Version:
 Severity:  normal       |  Resolution:
 Keywords:  dev-note     |     Focuses:
-------------------------+---------------------

Comment (by kraftbj):

 Replying to [comment:5 iandunn]:
 > Would it be better to just change the condition to `if ( ! is_admin() &&
 'cli' !== php_sapi_name() ) {` ?

 I don't see any other times in Core that we check for CLI (using that or
 `( defined( 'WP_CLI' ) && WP_CLI )`.

 I think it would be fine to add that, but are we good with adding the
 first CLI check to Core?

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/44171#comment:6>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list