[wp-trac] [WordPress Trac] #38323: Reconsider $object_subtype handling in `register_meta()`

WordPress Trac noreply at wordpress.org
Fri May 18 07:41:18 UTC 2018


#38323: Reconsider $object_subtype handling in `register_meta()`
-------------------------------------------------+-------------------------
 Reporter:  flixos90                             |       Owner:  flixos90
     Type:  enhancement                          |      Status:  assigned
 Priority:  normal                               |   Milestone:  5.0
Component:  Options, Meta APIs                   |     Version:
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch needs-unit-tests needs-    |     Focuses:  rest-api
  dev-note                                       |
-------------------------------------------------+-------------------------

Comment (by flixos90):

 As discussed in yesterday's chat, [attachment:38323.7.register-meta.diff]
 is an update that only contains the actual changes to `register_meta()`
 and the surrounding infrastructure. [attachment:38323.7.wrappers.diff]
 contains the wrapper functions (the latter patch requires the first one to
 work).

 This allows for a better overview:
 * The first patch is now pretty much final and only needs unit tests and a
 review.
 * The second patch is what is still up for debate. In the current state,
 it simply adds all wrapper functions with subtype as first parameter -
 which is likely not what we want, since comments and users don't have
 subtypes. But we can go from there and tweak the patch after we have come
 to a decision.

 Going forward, please iterate on the patches separately.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/38323#comment:56>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list