[wp-trac] [WordPress Trac] #44117: Privacy: Don't always link to the menu customizer

[WordPress Trac]

#44117: Privacy: Don't always link to the menu customizer
--------------------------+----------------------------
 Reporter:  dlh           |      Owner:  (none)
     Type:  defect (bug)  |     Status:  new
 Priority:  normal        |  Milestone:  4.9.7
Component:  Privacy       |    Version:  trunk
 Severity:  normal        |   Keywords:  has-patch gdpr
  Focuses:                |
--------------------------+----------------------------
 Currently, after saving the page for the site's privacy policy, a message
 displays with "Remember to update your menus!" that links to the menu
 customizer.

 In some situations, it might not make sense to include this message:

 1. When the user can't `edit_theme_options` and thus by default can't
 reach the Customizer.

 2. When the selected page for the privacy policy is unpublished, as
 unpublished pages can't be searched for by default in the menu customizer.

 3. When the current theme doesn't support menus, as the mention of a menu
 might confuse the user.

 The attached patch would skip the menu prompt after saving the setting in
 these cases.

 Of these cases, (3) seems to me like the most debatable, as users can
 still create menus in the Customizer even if the theme doesn't register a
 menu location. But (1) and (2) seem to me on firmer ground.

 A lighter touch could also be taken than what's in the patch, such as a
 message like "Remember to update your menus after the page is published!"
 for case (2).

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/44117>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform