[wp-trac] [WordPress Trac] #44091: Rename exports folder to avoid deleting other files

WordPress Trac noreply at wordpress.org
Tue May 15 20:21:39 UTC 2018


#44091: Rename exports folder to avoid deleting other files
------------------------------------------+----------------------
 Reporter:  iandunn                       |       Owner:  iandunn
     Type:  defect (bug)                  |      Status:  closed
 Priority:  high                          |   Milestone:  4.9.6
Component:  Administration                |     Version:  trunk
 Severity:  normal                        |  Resolution:  fixed
 Keywords:  gdpr has-patch needs-testing  |     Focuses:
------------------------------------------+----------------------
Changes (by iandunn):

 * owner:  (none) => iandunn
 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"43284" 43284]:
 {{{
 #!CommitTicketReference repository="" revision="43284"
 Privacy: Rename exports folder to avoid deleting other files.

 Previously, personal data exports were stored in `wp-
 content/uploads/exports`, which is generic enough that it's likely there
 are existing folders with that name, either created by plugins or manually
 by administrators. If that folder were reused by Core, then
 `wp_privacy_delete_old_export_files()` would delete all of the existing
 files inside it, which is almost certainly not what the site owner wants
 or expects.

 To avoid that, the folder is being renamed to include a specific reference
 to Core, and a more verbose description of its purpose. With those
 factored in, it's very unlikely that there will be any conflicts with
 existing folders.

 The `wp_privacy_exports_dir()` and `wp_privacy_exports_url()` functions
 were introduced to provide a canonical source for the location, and the
 `wp_privacy_exports_dir` and `wp_privacy_exports_url` filters were
 introduced to allow plugins to customize it.

 Props johnjamesjacoby, allendav.
 Fixes #44091.
 }}}

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/44091#comment:12>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list