[wp-trac] [WordPress Trac] #44091: Rename exports folder to avoid deleting other files

WordPress Trac noreply at wordpress.org
Tue May 15 19:27:24 UTC 2018


#44091: Rename exports folder to avoid deleting other files
------------------------------------------+-----------------------
 Reporter:  iandunn                       |       Owner:  (none)
     Type:  defect (bug)                  |      Status:  assigned
 Priority:  high                          |   Milestone:  4.9.6
Component:  Administration                |     Version:  trunk
 Severity:  normal                        |  Resolution:
 Keywords:  gdpr has-patch needs-testing  |     Focuses:
------------------------------------------+-----------------------

Comment (by allendav):

 Replying to [comment:8 Ov3rfly]:
 > > Attachment 44091.2.diff​ added
 >
 > New version uses trailingslashit() in a different way. Shouldn't the
 whole path be "trailingslashed"?


 True. I changed that on purpose to enforce the ending of
 $upload_dir['baseurl'] and $upload_dir['basedir'] before concatenation
 with the folder name

 >
 > And shouldn't 'basedir' be used with DIRECTORY_SEPARATOR instead of
 forward slash?

 Good idea.

 Also moved require_once to the actual place it is required (inside the
 cron job)

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/44091#comment:9>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list