[wp-trac] [WordPress Trac] #37392: Multisite "Sites" screen: Add links to filter websites by status

WordPress Trac noreply at wordpress.org
Tue May 15 17:08:37 UTC 2018

#37392: Multisite "Sites" screen: Add links to filter websites by status
 Reporter:  thomaswm                    |       Owner:  mnelson4
     Type:  enhancement                 |      Status:  assigned
 Priority:  normal                      |   Milestone:  Awaiting Review
Component:  Networks and Sites          |     Version:
 Severity:  normal                      |  Resolution:
 Keywords:  has-patch needs-unit-tests  |     Focuses:  multisite

Comment (by flixos90):

 Replying to [comment:21 mnelson4]:
 > I hear you that there shouldn't be a link with `?status=all`, so I made
 an adjustment that avoids that, but I do prefer how having `all` be in the
 array is avoids quite a bit of repeated code. If you still prefer not
 having `all` in the array, I can make another patch that does that.

 That's fine with me. One minor detail, please always use strict
 comparisons, there's a non-strict comparison in line 232.

 > I'm not sure where there should be blank lines. I double-checked the WP
 coding standards and don't see anything about where there should be blank
 lines. Could you point me to some documentation or help me see where blank
 lines are needed?

 Between docblock descriptions, since descriptions, param/return
 descriptions there should always be a blank line (blank meaning of course
 still put the asterisk there, but only that). For example between lines
 207, 208 and 209 in `class-wp-ms-sites-list-table.php` or lines 1544 and
 1545 in `ms-blogs.php`.

 > I double-checked that it's using real tabs instead of spaces for
 indentation and don't see where the indentation is wrong, sorry!

 For example line 1545 of `ms-blogs.php` there are several extra spaces
 between the variable name and description.

Ticket URL: <https://core.trac.wordpress.org/ticket/37392#comment:22>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform

More information about the wp-trac mailing list