[wp-trac] [WordPress Trac] #44080: Unreachable dead code in ID3/module.audio-video.quicktime.php

[WordPress Trac]

#44080: Unreachable dead code in  ID3/module.audio-video.quicktime.php
--------------------------+-----------------------------
 Reporter:  kikk          |      Owner:  (none)
     Type:  defect (bug)  |     Status:  new
 Priority:  normal        |  Milestone:  Awaiting Review
Component:  General       |    Version:  4.9.5
 Severity:  normal        |   Keywords:
  Focuses:                |
--------------------------+-----------------------------
 There are two consecutive blocks for
 case 'rmla' in QuicktimeParseAtom functions. The second will never be
 visited under any given condition.



 {{{
                         case 'rmla': // Reference Movie Language Atom
                                 $atom_structure['version']     =
 getid3_lib::BigEndian2Int(substr($atom_data,  0, 1));
                                 $atom_structure['flags_raw']   =
 getid3_lib::BigEndian2Int(substr($atom_data,  1, 3)); // hardcoded: 0x0000
                                 $atom_structure['language_id'] =
 getid3_lib::BigEndian2Int(substr($atom_data,  4, 2));
                                 $atom_structure['language']    =
 $this->QuicktimeLanguageLookup($atom_structure['language_id']);
                                 if (empty($info['comments']['language'])
 || (!in_array($atom_structure['language'],
 $info['comments']['language']))) {
                                         $info['comments']['language'][] =
 $atom_structure['language'];
                                 }
                                 break;
                         case 'rmla': // Reference Movie Language Atom
                                 $atom_structure['version']   =
 getid3_lib::BigEndian2Int(substr($atom_data,  0, 1));
                                 $atom_structure['flags_raw'] =
 getid3_lib::BigEndian2Int(substr($atom_data,  1, 3)); // hardcoded: 0x0000
                                 $atom_structure['track_id']  =
 getid3_lib::BigEndian2Int(substr($atom_data,  4, 2));
                                 break;
 }}}


 Here is a pointer to the issue ->

 https://github.com/WordPress/wordpress-
 develop/blob/e72d50370273c2741329e1a102ec90b35cf1b492/src/wp-
 includes/ID3/module.audio-video.quicktime.php#L690

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/44080>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform