[wp-trac] [WordPress Trac] #44071: Unreachable condition in elseIF

[WordPress Trac]

#44071: Unreachable condition in elseIF
--------------------------+------------------------------
 Reporter:  akshayar      |       Owner:  (none)
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  Awaiting Review
Component:  General       |     Version:  4.9.5
 Severity:  normal        |  Resolution:
 Keywords:  needs-patch   |     Focuses:
--------------------------+------------------------------
Changes (by swissspidy):

 * keywords:  has-patch => needs-patch


Old description:

> There is duplicate 'is_post_type_archive' conditional check-in 'elseif'
> condition. You can check 'feed_links_extra()' function located at
> 'general-template.php' file under 'wp-includes' directory conatains,
>
> https://github.com/WordPress/WordPress/blob/master/wp-includes/general-
> template.php#L2799
>
> This block will never get executed.

New description:

 There is duplicate 'is_post_type_archive' conditional check-in 'elseif'
 condition. You can check 'feed_links_extra()' function located at
 'general-template.php' file under 'wp-includes' directory conatains,

 https://github.com/WordPress/WordPress/blob/e76593098293fd1e87d666bd3acf339b46fd5110
 /wp-includes/general-template.php#L2799

 This block will never get executed.

--

Comment:

 The first `elseif` is here:
 https://github.com/WordPress/WordPress/blob/e76593098293fd1e87d666bd3acf339b46fd5110
 /wp-includes/general-template.php#L2763

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/44071#comment:1>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform