[wp-trac] [WordPress Trac] #43985: Privacy: The user request email should be sent in the user language

[WordPress Trac]

#43985: Privacy: The user request email should be sent in the user language
-------------------------------------------------+-------------------------
 Reporter:  Chouby                               |       Owner:  desrosj
     Type:  defect (bug)                         |      Status:  accepted
 Priority:  normal                               |   Milestone:  4.9.6
Component:  Mail                                 |     Version:  trunk
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch gdpr needs-testing needs-  |     Focuses:
  unit-tests                                     |  administration
-------------------------------------------------+-------------------------
Changes (by iandunn):

 * keywords:  has-patch gdpr needs-testing => has-patch gdpr needs-testing
     needs-unit-tests
 * focuses:   => administration
 * component:  General => Mail


Comment:

 I think the fallback locale for visitors should be the site's default
 locale, rather than the current admin's locale. For example, the admin
 could be a native Spanish speaker who also speaks English, and is
 moderating an English site. For their convenience, they set Spanish as
 their user locale. The visitor to an English site is more likely to speak
 English than Spanish, though.

 [attachment:43985.3.diff] makes that change, and also simplifies the code
 by relying on the fact that `get_user_locale()` falls back to
 `get_locale()`, and that there's a helper function for
 `is_locale_switched()`.

 That tests well for me, but since we're in RC, can I ask a few of you to
 test it as well, before I commit it to `trunk`? Then we can ask another
 committer review it for backport to 4.9 branch.

 If someone has time to write unit tests, that'd be great too (that's true
 of [https://core.trac.wordpress.org/query?status=!closed&keywords=~needs-
 unit-tests&milestone=4.9.6 the 4.9 tickets in general]).

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/43985#comment:9>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform