[wp-trac] [WordPress Trac] #43232: User signups should be marked `active=0` after account is deleted

[WordPress Trac]

#43232: User signups should be marked `active=0` after account is deleted
--------------------------+------------------------------
 Reporter:  boonebgorges  |       Owner:  (none)
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  Awaiting Review
Component:  Users         |     Version:  3.0
 Severity:  normal        |  Resolution:
 Keywords:  2nd-opinion   |     Focuses:  multisite
--------------------------+------------------------------

Comment (by pbiron):

 Setting `active=0` would make the database more "internally consistent"
 but it doesn't actually make "the problem go away".

 This is because the queries in
 [[https://core.trac.wordpress.org/browser/tags/4.9.2/src/wp-includes/ms-
 functions.php?marks=503-524#L499|wpmu_validate_user_signup()]] don't
 bother to check `active`.  So, if a user activates their account, then
 deletes its and tries to register again (within the 2 day window) they
 would still get the `That username is currently reserved but may be
 available in a couple of days.` error message.

 I'm curious: why isn't the relevant row from `wp_signups` deleted when the
 user account is delete?

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/43232#comment:1>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform