[wp-trac] [WordPress Trac] #43929: Privacy pages: buttons should be buttons and other coding standards

WordPress Trac noreply at wordpress.org
Thu May 10 07:35:22 UTC 2018


#43929: Privacy pages: buttons should be buttons and other coding standards
------------------------------------------+-------------------------------
 Reporter:  afercia                       |       Owner:  (none)
     Type:  defect (bug)                  |      Status:  new
 Priority:  normal                        |   Milestone:  4.9.6
Component:  Administration                |     Version:  trunk
 Severity:  normal                        |  Resolution:
 Keywords:  gdpr has-patch needs-testing  |     Focuses:  coding-standards
------------------------------------------+-------------------------------

Comment (by xkon):

 Some extra minor CS fixes in [attachment:43929.6.diff] . Other than that
 it looks good to me and applies & works without issues @desrosj .

 {{{
 wp-admin\js\xfn.js

 @218 spaces to tabs
 @222 spaces to tabs
 @227 spaces to tabs
 @229 spaces to tabs
 @234 new line above comment
 @264 convert `} )( jQuery );` to `} ( jQuery ) );`
 }}}
 {{{
 wp-admin\includes\user.php

 @666 remove empty line
 @1115 space before `: '';`
 @1218 space before `: 0;`
 @1480 `,` after array
 }}}

 {{{
 wp-includes\user.php
 @3081 align `=`
 @3114 space before `: 0;`
 }}}

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/43929#comment:15>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list