[wp-trac] [WordPress Trac] #43940: Privacy Policy Settings: Don't show page selector if you don't have any pages

[WordPress Trac]

#43940: Privacy Policy Settings: Don't show page selector if you don't have any
pages
-------------------------------------------------+-------------------------
 Reporter:  melchoyce                            |       Owner:  (none)
     Type:  defect (bug)                         |      Status:  new
 Priority:  normal                               |   Milestone:  4.9.6
Component:  General                              |     Version:
 Severity:  normal                               |  Resolution:
 Keywords:  gdpr needs-testing has-patch needs-  |     Focuses:  ui,
  refresh                                        |  administration
-------------------------------------------------+-------------------------
Changes (by desrosj):

 * keywords:  gdpr has-patch needs-testing 2nd-opinion => gdpr needs-testing
     has-patch needs-refresh


Comment:

 I think it should be there, in my opinion. The text before it says "Select
 a Privacy Policy page". I think it feels weird if there is no input and no
 message. I think it will also be rare someone does not see a dropdown.

 In addition, here is some feedback on [attachment:43940-2.diff]:

 - Please use tabs to indent instead of spaces.
 - There should be spaces before and after variables in function calls,
 after control structures. Example: `if( !empty($page_list) ){` should be
 `if ( ! empty( $page_list ) ) {`
 - Arrays with values on multiple lines should be aligned at the `=>`
 - I think the "Or create a new page" text can go away. That is implied by
 the button text. If anything, it could read just "or"

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/43940#comment:11>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform