[wp-trac] [WordPress Trac] #43583: Introduce new PHP cross-version compat function `is_countable()`

[WordPress Trac]

#43583: Introduce new PHP cross-version compat function `is_countable()`
-------------------------------------------------+-------------------------
 Reporter:  jrf                                  |       Owner:
                                                 |  SergeyBiryukov
     Type:  enhancement                          |      Status:  reopened
 Priority:  normal                               |   Milestone:  4.9.6
Component:  General                              |     Version:
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch has-unit-tests needs-dev-  |     Focuses:
  note commit                                    |
-------------------------------------------------+-------------------------
Changes (by desrosj):

 * keywords:  has-patch has-unit-tests needs-dev-note needs-refresh => has-
     patch has-unit-tests needs-dev-note commit


Comment:

 In [attachment:43583.diff]:

 - Fix alignment of new conditional statements.
 - Added parameter inline documentation for
 `test_is_countable_functionality()`.
 - Split out `SimpleXMLElement` and `ResourceBundle` tests into their own
 test methods so that they can be marked as skipped if their respective
 extensions are not loaded.
 - Change `assertEquals()` to `assertSame()` in
 `test_is_countable_functionality()` for stricter type checking.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/43583#comment:21>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform