[wp-trac] [WordPress Trac] #43936: Settings: Warn when open registration and new user default is privileged
WordPress Trac
noreply at wordpress.org
Sat May 5 03:11:17 UTC 2018
#43936: Settings: Warn when open registration and new user default is privileged
--------------------------+------------------------------
Reporter: kraftbj | Owner: (none)
Type: defect (bug) | Status: new
Priority: normal | Milestone: Awaiting Review
Component: Users | Version:
Severity: normal | Resolution:
Keywords: has-patch | Focuses: administration
--------------------------+------------------------------
Comment (by kraftbj):
Thanks for the patch @subrataemfluence! A couple of logistical notes on
the patch - It is helpful to run the svn diff from the root so you have
the full path (e.g. src/wp-admin/includes/template.php instead of just
template.php). That'll make it easier to apply to patch.
Also, be sure your code follow WordPress Coding Standards (
https://make.wordpress.org/core/handbook/best-practices/coding-
standards/php/ ). There were a few spacing issues that I noticed.
Submitting a follow-up patch that includes updated inline docs, coding
standards compliance, and implements the modified `wp_dropdown_roles` to
resolve the ticket issue.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/43936#comment:4>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list