[wp-trac] [WordPress Trac] #43650: Add Requires PHP Version to Plugin - View Details

[WordPress Trac]

#43650: Add Requires PHP Version to Plugin - View Details
-------------------------------------------------+-------------------------
 Reporter:  xkon                                 |       Owner:
                                                 |  SergeyBiryukov
     Type:  enhancement                          |      Status:  closed
 Priority:  normal                               |   Milestone:  4.9.6
Component:  Plugins                              |     Version:
 Severity:  normal                               |  Resolution:  fixed
 Keywords:  has-patch has-screenshots commit     |     Focuses:
  fixed-major servehappy                         |  administration
-------------------------------------------------+-------------------------

Comment (by mnelson4):

 Smart feature @xkon!
 Wouldn’t the string be more translatable if it used a placeholder instead
 of assuming all languages want the number to come to the right of the
 string?

 Eg instead of

 `_e( 'Requires PHP Version:' ); ... printf( __( '%s or higher' ),
 $api->requires_php );`

 we should have
 `printf( __( 'Requires PHP Version %s or higher' ), $api->requires_php );`


 I would think this would he more friendly to right-to-left languages, no?
 But that will of course add a new string to be translated, and maybe
 that’s not an option...

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/43650#comment:14>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform