[wp-trac] [WordPress Trac] #43909: Improve styling on personal data tables

WordPress Trac noreply at wordpress.org
Tue May 1 23:34:03 UTC 2018


#43909: Improve styling on personal data tables
------------------------------------------+------------------------------
 Reporter:  allendav                      |       Owner:  (none)
     Type:  defect (bug)                  |      Status:  new
 Priority:  normal                        |   Milestone:  Awaiting Review
Component:  General                       |     Version:  trunk
 Severity:  normal                        |  Resolution:
 Keywords:  gdpr has-patch needs-testing  |     Focuses:
------------------------------------------+------------------------------

Comment (by allendav):

 Replying to [comment:4 melchoyce]:
 > It looks like you're not reusing existing notice classes — is there a
 reason you're duplicating the CSS in new classes instead of using existing
 classes?

 Hi @melchoyce  ! We looked at the plugins page to mimic how it is
 constructed and styled and we do use .notice, .inline, .notice-alt,
 .notice-error from common.css on this page in the same way as the plugins
 page.

 As for the box-shadow removal and background color copying - the styles on
 the plugins page are plugins table specific (in list-tables.css with
 things like .plugins .update td) and that's why I duplicated a tiny bit of
 CSS here for the requests tables.

 Is that what you mean?

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/43909#comment:5>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list