[wp-trac] [WordPress Trac] #43438: Add filters and Ajax support for personal data export

WordPress Trac noreply at wordpress.org
Tue May 1 08:38:08 UTC 2018


#43438: Add filters and Ajax support for personal data export
-----------------------------------------------+-----------------------
 Reporter:  azaozz                             |       Owner:  desrosj
     Type:  enhancement                        |      Status:  assigned
 Priority:  normal                             |   Milestone:  4.9.6
Component:  General                            |     Version:
 Severity:  normal                             |  Resolution:
 Keywords:  gdpr needs-unit-tests needs-patch  |     Focuses:
-----------------------------------------------+-----------------------

Comment (by birgire):

 The patch in [attachment:43438.9.diff]:

 - Adds checks if array keys are set in {{{$_POST}}}, else send an error,
 for these cases:


 {{{
 $request_id     = (int) $_POST['id'];
 $exporter_index = (int) $_POST['exporter'];
 $eraser_index   = (int) $_POST['eraser'];
 $page           = (int) $_POST['page'];

 }}}

 - Adds order to multiple placeholders in translation strings. For example
 {{{%s, %d}}} to {{{'%1$s, %2$d}}}.
 - Adds "translators:" comments.
 - Removes {{{Error:}}} in error messages. We already have ''"An error
 occurred while attempting to erase/export personal data"'' displayed
 before the error message. Also for consistency, because not all error
 messages start with {{{Error:}}}. See
 [attachment:error_response_without_Error_string_part.jpg].
 - Adjusts the doc block for the {{{wp_privacy_personal_data_export_page
 filter}}}
         - Adds the possible {{{WP_Error}}} to inline doc for
 {{{$response}}}.
         - Removes the "zero-based" from the inline doc for {{{$page}}}.
 - Adjusts the doc block for the
 {{{wp_privacy_personal_data_erasure_page}}} filter
         - Adds the possible {{{WP_Error to inline doc for {{{$response}}}.
         - Removes the "zero-based" from the inline doc for {{{$page}}}.
 - Further adjustments to the Coding Standard.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/43438#comment:42>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list