[wp-trac] [WordPress Trac] #43438: Add filters and Ajax support for personal data export
WordPress Trac
noreply at wordpress.org
Wed Mar 28 20:06:13 UTC 2018
#43438: Add filters and Ajax support for personal data export
-----------------------------------------------+------------------
Reporter: azaozz | Owner:
Type: enhancement | Status: new
Priority: normal | Milestone: 5.0
Component: General | Version:
Severity: normal | Resolution:
Keywords: gdpr needs-unit-tests needs-patch | Focuses:
-----------------------------------------------+------------------
Changes (by ocean90):
* keywords: gdpr has-patch needs-unit-tests => gdpr needs-unit-tests
needs-patch
Comment:
[42889] has a few issues which need to be addressed:
* `wp_ajax_wp_privacy_export_personal_data()` has no DocBlock.
* The mbstring PHP extension might be not available, so `mb_strtolower()`
needs `function_exists()` check. Note that `is_email()` currently doesn't
support email addresses with multibyte characters so `strtolower()` should
be enough.
* The docs for the `wp_privacy_personal_data_exporters`filter doesn't
match the [https://make.wordpress.org/core/handbook/best-practices/inline-
documentation-standards/php/#1-1-parameters-that-are-arrays docs
standards].
* It seems like `$_POST['exporter']` is an numeric index of an exporter.
Wouldn't it be easier if exporters are referenced by a name instead?
* What's the idea behind the error messages? Should probably be
translatable or a code instead.
* The nonce check should be enabled.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/43438#comment:34>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list