[wp-trac] [WordPress Trac] #43440: Add personal data from comments to personal data export

[WordPress Trac]

#43440: Add personal data from comments to personal data export
----------------------------------------+------------------
 Reporter:  azaozz                      |       Owner:
     Type:  enhancement                 |      Status:  new
 Priority:  normal                      |   Milestone:  5.0
Component:  Administration              |     Version:
 Severity:  normal                      |  Resolution:
 Keywords:  gdpr has-patch 2nd-opinion  |     Focuses:
----------------------------------------+------------------

Comment (by birgire):

 Will GDPR support in WordPress be backported to older versions?

 If not then in {{{wp_comments_personal_data_exporter()}}} one could use
 {{{paged}}} for pagination in {{{get_comments()}}} instead of calculating
 an {{{$offset}}}.

 This is supported in {{{WP_Comment_Query}}} since 4.9 (#38268)


 If it will be backported, then I wonder if it will be more clear to use a
 "1-based" pagination, instead of "0-based".

 As it might be confusing that {{{page=0}}} is the first page, and
 {{{page=1}}} is the second page, etc.

 So instead of:

 {{{
 $offset = $number * $page;

 }}}

 where {{{$page >= 0}}}, we would use:

 {{{
 $offset = $number * ( $page - 1 );

 }}}

 where {{{$page >= 1}}}.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/43440#comment:17>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform