[wp-trac] [WordPress Trac] #43644: Revert multiline calls to actions and filters

WordPress Trac noreply at wordpress.org
Tue Mar 27 14:22:38 UTC 2018


#43644: Revert multiline calls to actions and filters
-------------------------------------+-------------------------------------
 Reporter:  johnbillion              |       Owner:  johnbillion
     Type:  task (blessed)           |      Status:  accepted
 Priority:  normal                   |   Milestone:  5.0
Component:  General                  |     Version:  trunk
 Severity:  normal                   |  Resolution:
 Keywords:  needs-patch 2nd-opinion  |     Focuses:  docs, coding-standards
-------------------------------------+-------------------------------------

Comment (by ocean90):

 While I think multiline calls are fine per se, the "code is poetry" commit
 has made them actually not so poetry IMO. Comparing `wp_comment_reply` and
 `list_cats`, wouldn't it be more readable if `wp_comment_reply` would be
 like this:

 {{{#!php
 <?php
 $content = apply_filters(
         'wp_comment_reply',           // First arg.
         '',                           // Second arg.
         array(                        // Third arg.
                 'position' => $position,
                 'checkbox' => $checkbox,
                 'mode'     => $mode,
         )
 );
 }}}

--
Ticket URL: <https://core.trac.wordpress.org/ticket/43644#comment:4>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list