[wp-trac] [WordPress Trac] #43633: Duplicate links to edit profile dropdown in toolbar

[WordPress Trac]

#43633: Duplicate links to edit profile dropdown in toolbar
-------------------------------------------------+-------------------------
 Reporter:  danieltj                             |       Owner:
     Type:  enhancement                          |      Status:  new
 Priority:  normal                               |   Milestone:  Awaiting
Component:  Toolbar                              |  Review
 Severity:  normal                               |     Version:
 Keywords:  has-patch needs-testing 2nd-opinion  |  Resolution:
                                                 |     Focuses:  ui
-------------------------------------------------+-------------------------
Changes (by danieltj):

 * keywords:  has-patch needs-testing => has-patch needs-testing 2nd-opinion


Comment:

 Replying to [comment:7 netweb]:
 > I stand by what I wrote in comment:5, the primary purpose of the
 `wp_admin_bar_my_account_menu()` function is to add "My Account" items to
 the admin bar which are the ''user profile'' links, first the user profile
 [https://core.trac.wordpress.org/browser/trunk/src/wp-includes/admin-
 bar.php#L291 #L291], and then, if it is not multisite
 [https://core.trac.wordpress.org/browser/trunk/src/wp-includes/admin-
 bar.php#L266 #L266] the "Edit My Profile" link is added.
 >
 > [attachment:43633.2.diff] changes multisite behaviour by changing the
 first link to link to a users post archive rather than the current link to
 the dashboard [https://core.trac.wordpress.org/browser/trunk/src/wp-
 includes/admin-bar.php#L267 #L267], this is currently used I expect due to
 all of the multisite blog/site/network juggling complexities that are
 required to retrieve any user related content in multisite environments.
 >
 > Also adding a filter as proposed in [attachment:43633.2.diff] puts the
 onus on developers to opt-out of a what is a breaking change being
 introduced into WordPress and these types of change should be avoided.

 How do we fix the issue of having two links to the same page though? As it
 stands, single-site installs have two links to the same place which isn't
 useful and is confusing. In [attachment:43633.2.diff], the ids are kept
 the same to ensure additional links are still added correctly to the
 toolbar, the link location has simply changed.

 There is another way to the dashboard on multisites anyway on the left
 hand side, so access to these account pages isn't lost and still very
 accessible. The aim here is to change the fact we have two links going to
 the same page right next to each other. A much better use of toolbar UI
 would be to provide a link to somewhere that is hard to find.

 Adding 2nd-opinion to get more thoughts on this.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/43633#comment:8>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform