[wp-trac] [WordPress Trac] #43536: Network registration page

[WordPress Trac]

#43536: Network registration page
------------------------------------+------------------------------
 Reporter:  SGr33n                  |       Owner:
     Type:  defect (bug)            |      Status:  new
 Priority:  normal                  |   Milestone:  Awaiting Review
Component:  Login and Registration  |     Version:
 Severity:  normal                  |  Resolution:
 Keywords:                          |     Focuses:  multisite
------------------------------------+------------------------------

Comment (by jeremyfelt):

 Hi @SGr33n, thanks for the ticket.

 I think this can be traced to an assumption where if a
 [https://github.com/WordPress/wordpress-
 develop/blob/8df8cf2df14fe26174f97af5bb17d63f2e867231/src/wp-includes
 /class-wp-query.php#L949 query isn't detected to be anything else], then
 we assume `is_home()` is `true`.

 Lacking some kind of `is_wp_signup()` or a refactor of that area, there
 might not be a great way of avoiding the page ID being output.

 A couple possibilities:

 * Add a `body_class` filter in `wp-signup.php` to always add a `wp-signup`
 or similar class.
 * Leave it to themes to check `$_SERVER['REQUEST_URI']` or `$wp->request`
 and add their own body class filter.

 My gut says that if we add a filter in `wp-signup.php`, we should do so
 after things have been refactored via a ticket like #31928 or #33500. It's
 entirely possible to add a filter at the theme level now and if we made
 changes to `wp-signup.php`, we add to the list of things to keep track of.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/43536#comment:3>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform