[wp-trac] [WordPress Trac] #43539: Custom feed types breaks redirect_canonical behavior

[WordPress Trac]

#43539: Custom feed types breaks redirect_canonical behavior
------------------------------------------+------------------------------
 Reporter:  satantime                     |       Owner:
     Type:  defect (bug)                  |      Status:  new
 Priority:  normal                        |   Milestone:  Awaiting Review
Component:  Canonical                     |     Version:  4.9.4
 Severity:  normal                        |  Resolution:
 Keywords:  needs-unit-tests needs-patch  |     Focuses:
------------------------------------------+------------------------------

Comment (by satantime):

 If you would check code above then you can see there's no location:
 because `// protect against chained redirects` on line 532 is triggered.
 It is triggered because wp doesn't respect custom feed types properly and
 instead of to resolve `/feed/type/` as `/feed/type/` and does nothing, or
 just redirects `/feed/type` to `/feed/type/`, and doesn't trigger extra
 redirects as `/feed/type/feed/type/` to `/feed/type/feed/type/feed/type/`
 and to so on. So `// protect against chained redirects` is hotfix for
 broken implementation about custom feed types.

 Your doubt are wrong.
 if you can see this bug isn't theoretical, it's real and requires real
 fix.
 I would suggest you to show that task to someone from engineering team and
 they'll understand the problem instantly. I know how it's hard to work
 with code when there's not enough experience with it.

 About patch and unit test - might you point me to source code repo, I can
 implement everything without an issue, so right guy just need to click
 merge button.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/43539#comment:12>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform