[wp-trac] [WordPress Trac] #43566: CS: Fix elseif in WordPress core files
WordPress Trac
noreply at wordpress.org
Fri Mar 16 19:46:23 UTC 2018
#43566: CS: Fix elseif in WordPress core files
--------------------------+-------------------------------------
Reporter: mukesh27 | Owner:
Type: defect (bug) | Status: closed
Priority: normal | Milestone:
Component: General | Version:
Severity: normal | Resolution: invalid
Keywords: has-patch | Focuses: docs, coding-standards
--------------------------+-------------------------------------
Changes (by afercia):
* status: new => closed
* resolution: => invalid
* milestone: Awaiting Review =>
Comment:
Thanks @mukesh27. As @birgire said, patches must be generated from a
checkout of the development repository, which is the trunk version of
WordPress with all the latest changes. Unfortunately, creating patches
from a released version is not recommended, as many things have changed in
the codebase in the meantime.
Specifically, a recent change that will be released with WordPress 5.0
fixed many coding standards in the codebase, see
https://core.trac.wordpress.org/changeset/42343
and for the admin bar:
https://core.trac.wordpress.org/changeset/42343/trunk/src/wp-includes
/admin-bar.php
Worth also noting files related to external libraries are not required to
meet the coding standards.
You can find more details about the recommended practices to contribute to
WordPress in the developers handbook:
https://make.wordpress.org/core/handbook/contribute/
How to install manually a copy of trunk from the development repository:
https://make.wordpress.org/core/handbook/tutorials/installing-wordpress-
locally/from-svn/#1-check-out-wordpress-trunk
Or, just use VVV:
https://make.wordpress.org/core/handbook/tutorials/installing-a-local-
server/installing-vvv/
Going to close this ticket since your proposed change is already in core
:) Thanks again.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/43566#comment:7>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list