[wp-trac] [WordPress Trac] #43481: Add tabs and placeholders to privacy tools page in wp-admin

[WordPress Trac]

#43481: Add tabs and placeholders to privacy tools page in wp-admin
------------------------------+------------------------------
 Reporter:  xkon              |       Owner:
     Type:  enhancement       |      Status:  new
 Priority:  normal            |   Milestone:  Awaiting Review
Component:  General           |     Version:
 Severity:  normal            |  Resolution:
 Keywords:  gdpr 2nd-opinion  |     Focuses:
------------------------------+------------------------------

Comment (by allendav):

 A few more things from a review of the code:

 - there are inconsistent indents in src/wp-admin/css/forms.css for the
 body.privacy-php .privacy-information .tab-content rules
 - there is inconsistent whitespace (e.g. around this) in src/wp-
 admin/js/xfn.js - codesniffer/wp standards could help
 - in src/wp-admin/privacy.php "front-static-pages" is a boo boo from my
 old patch - lets use "privacy-policy-page" or some such instead
 - also, in privacy.php, I think instead of _e and esc_attr_e in the
 requests headings, table cells and buttons you want esc_html_e, no?
 - and, still in privacy.php, same thing (esc_html_e instead of _e) for the
 privacy policy information tabs and headings

--
Ticket URL: <https://core.trac.wordpress.org/ticket/43481#comment:12>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform