[wp-trac] [WordPress Trac] #42729: Permit use of 'text-transform' in safecss_filter_attr()

[WordPress Trac]

#42729: Permit use of 'text-transform' in safecss_filter_attr()
-------------------------------------------------+-------------------------
 Reporter:  danielbachhuber                      |       Owner:  juiiee8487
     Type:  enhancement                          |      Status:  assigned
 Priority:  normal                               |   Milestone:  Future
Component:  Editor                               |  Release
 Severity:  normal                               |     Version:
 Keywords:  good-first-bug has-patch has-unit-   |  Resolution:
  tests                                          |     Focuses:
-------------------------------------------------+-------------------------
Changes (by birgire):

 * keywords:  needs-unit-tests good-first-bug has-patch => good-first-bug
     has-patch has-unit-tests


Comment:

 The patch in [attachment:42729.diff] looks good.

 There are currently no explicit tests for the {{{safecss_filter_attr()}}}
 function.

 The patch in [attachment:42729.2.diff]
 - adds {{{@since}}} in the docblock of the {{{safecss_filter_attr()}}}
 function.
 - adds tests for the {{{safecss_filter_attr()}}} function with a data
 provider.

 There's a suggested
 [https://core.trac.wordpress.org/attachment/ticket/24157/kses.diff patch]
 by @joehoyle in #24157 for tests, that we could also consider.

 But it looks like that patch is blocked by the discussion of allowing
 parentheses.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/42729#comment:5>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform