[wp-trac] [WordPress Trac] #43055: Reorganize Core JS / introduce build step

[WordPress Trac]

#43055: Reorganize Core JS / introduce build step
------------------------------+-------------------------
 Reporter:  omarreiss         |       Owner:
     Type:  enhancement       |      Status:  new
 Priority:  normal            |   Milestone:  5.0
Component:  Build/Test Tools  |     Version:  trunk
 Severity:  normal            |  Resolution:
 Keywords:  dev-feedback      |     Focuses:  javascript
------------------------------+-------------------------

Comment (by omarreiss):

 Working towards completion:

 The Grunt patch PR was merged. https://github.com/WordPress/grunt-patch-
 wordpress/pull/54. File mapping is included in the latest patch.

 I went through all of the file diffs between master build directory and
 the build directory after patch. Verified there are no logic differences
 anymore. Here's the summary:


 {{{
 Files compare/build/wp-includes/js/backbone.min.js and mirror/build/wp-
 includes/js/backbone.min.js differ
 └ Only difference is a sourcemap comment which was omitted in the current
 build.

 Files compare/build/wp-includes/js/hoverIntent.js and mirror/build/wp-
 includes/js/hoverIntent.js differ
 └ Only difference is a version number in the comment. NPM version was
 unauthorized before. This is fixed and the reason why the versions diff.

 Files compare/build/wp-includes/js/imagesloaded.min.js and mirror/build
 /wp-includes/js/imagesloaded.min.js differ
 └ Code is identical, was minified twice in the current build. Fixed in
 patch.

 Files compare/build/wp-includes/js/jquery/jquery.color.min.js and
 mirror/build/wp-includes/js/jquery/jquery.color.min.js differ
 └ Code is identical, only difference is minification variable names.

 Files compare/build/wp-includes/js/media-audiovideo.js and mirror/build
 /wp-includes/js/media-audiovideo.js differ
 Files compare/build/wp-includes/js/media-audiovideo.min.js and
 mirror/build/wp-includes/js/media-audiovideo.min.js differ
 Files compare/build/wp-includes/js/media-grid.js and mirror/build/wp-
 includes/js/media-grid.js differ
 Files compare/build/wp-includes/js/media-grid.min.js and mirror/build/wp-
 includes/js/media-grid.min.js differ
 Files compare/build/wp-includes/js/media-models.js and mirror/build/wp-
 includes/js/media-models.js differ
 Files compare/build/wp-includes/js/media-models.min.js and mirror/build
 /wp-includes/js/media-models.min.js differ
 Files compare/build/wp-includes/js/media-views.js and mirror/build/wp-
 includes/js/media-views.js differ
 Files compare/build/wp-includes/js/media-views.min.js and mirror/build/wp-
 includes/js/media-views.min.js differ
 └ The way media files are built has slightly changed which results in some
 bundling / minification diffs.

 Files compare/build/wp-includes/js/underscore.min.js and mirror/build/wp-
 includes/js/underscore.min.js differ
 └ Only difference is a sourcemap comment which was omitted in the current
 build.

 Files compare/build/wp-includes/js/zxcvbn.min.js and mirror/build/wp-
 includes/js/zxcvbn.min.js differ
 └ Looks like the current file is broken. The forbidden passwords look
 scrambled. Fixed in patch.
 }}}

 This means codewise this is ready to go. Current patch enforces build step
 and requires to run from `/build`.
 I contacted @tjnowell on WP Slack to discuss steps for VVV. I'd also love
 to know about other dev platform maintainers I should contact. It will be
 best if they are mostly prepared.

 Will spend another half day on documentation this weekend. Would like to
 move to inclusion starting monday. @pento is this something you could help
 with?

--
Ticket URL: <https://core.trac.wordpress.org/ticket/43055#comment:32>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform