[wp-trac] [WordPress Trac] #43443: Add a method for confirmation of requests for deleting or anonymizing of personal data

[WordPress Trac]

#43443: Add a method for confirmation of requests for deleting or anonymizing of
personal data
-------------------------------------------------+-------------------------
 Reporter:  azaozz                               |       Owner:  mikejolley
     Type:  enhancement                          |      Status:  assigned
 Priority:  normal                               |   Milestone:  5.0
Component:  General                              |     Version:
 Severity:  normal                               |  Resolution:
 Keywords:  gdpr has-patch dev-feedback needs-   |     Focuses:
  testing                                        |
-------------------------------------------------+-------------------------

Comment (by ocean90):

 Replying to [comment:3 azaozz]:
 > In [changeset:"42791"]:
 > {{{
 > #!CommitTicketReference repository="" revision="42791"
 > Add a method to confirm user requests by email. First run.
 >
 > Props mikejolley.
 > See #43443.
 > }}}

 * `hash()` may not be available, see #29518.
 * `@return WP_ERROR|bool` should be `@return WP_Error|bool`.
 * There should be no empty line between `@param` and `@return` tags.
 * All the `WP_Error` messages should end with a full stop.
 * In `check_confirm_account_action_key` the function should bail directly
 if one of the parameters is empty. So move that `return new WP_Error(
 'invalid_key', __( 'Invalid key' ) );` line up to avoid one huge if
 condition.
 * All the new actions have no `@since` tag.
 * Why are none of the functions prefixed with `wp_`?

--
Ticket URL: <https://core.trac.wordpress.org/ticket/43443#comment:6>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform