[wp-trac] [WordPress Trac] #43483: login css imports styles it has as dependencies

WordPress Trac noreply at wordpress.org
Wed Mar 7 09:57:12 UTC 2018


#43483: login css imports styles it has as dependencies
------------------------------------+------------------------------
 Reporter:  alpipego                |       Owner:
     Type:  defect (bug)            |      Status:  new
 Priority:  normal                  |   Milestone:  Awaiting Review
Component:  Login and Registration  |     Version:  4.8.3
 Severity:  normal                  |  Resolution:
 Keywords:                          |     Focuses:
------------------------------------+------------------------------

Comment (by alpipego):

 No, that's not what I am saying (it's actually the opposite). If you look
 at the source of {{{wp-admin/css/login.css}}} it imports {{{forms.css}}}
 and {{{i10n.css}}}:

 {{{#!css
 @import url(forms.css);
 @import url(l10n.css);
 }}}

 And in https://core.trac.wordpress.org/browser/trunk/src/wp-includes
 /script-loader.php#L1075 these two scripts are also added as dependencies
 to {{{login.css}}}, which is redundant:

 {{{#!php
 $styles->add( 'login', "/wp-admin/css/login$suffix.css", array(
 'dashicons', 'buttons', 'forms', 'l10n' ) );
 }}}

 I think we should get rid of the one of the two and I propose removing the
 {{{@import}}} statements.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/43483#comment:2>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list