[wp-trac] [WordPress Trac] #41191: Create browse happy type notice for PHP versions

[WordPress Trac]

#41191: Create browse happy type notice for PHP versions
-------------------------------------------------+-------------------------
 Reporter:  joostdevalk                          |       Owner:  flixos90
     Type:  enhancement                          |      Status:  assigned
 Priority:  normal                               |   Milestone:  5.0
Component:  General                              |     Version:
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch has-unit-tests needs-      |     Focuses:
  testing needs-design ui-feedback               |
-------------------------------------------------+-------------------------
Changes (by pento):

 * keywords:  has-patch has-unit-tests needs-testing => has-patch has-unit-
     tests needs-testing needs-design ui-feedback


Comment:

 A couple of code notes:

 - `dashboard.php:41`, remove the `!` from the ternary operator and swap
 the strings.
 - For the `$update_url` `if` statement, please don't introduce new
 instances of `if` / `endif` notation.

 The text in the widget is going to need rewriting to fit the usual voice
 in Core. It'd be worth having this reviewed by the Design and Marketing
 teams.

 Also, the double button behaviour when `$update_url` needs a review from
 the Design team. This is presumably so hosts can add a `mu-plugin` that
 directs to their upgrade routines? Rather than confusing the issue with
 two buttons, it seems like this should just be a single button that sends
 you to the host's upgrade page. At the very least, I suspect the strings
 being a split sentence will cause translation issues.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/41191#comment:44>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform