[wp-trac] [WordPress Trac] #38674: Semantic elements for non-link links: update-core.php (show/hide hidden updates)

WordPress Trac noreply at wordpress.org
Sun Mar 4 20:59:15 UTC 2018


#38674: Semantic elements for non-link links: update-core.php (show/hide hidden
updates)
-------------------------------------+-------------------------------------
 Reporter:  Cheffheid                |       Owner:  afercia
     Type:  enhancement              |      Status:  assigned
 Priority:  normal                   |   Milestone:  5.0
Component:  Administration           |     Version:
 Severity:  normal                   |  Resolution:
 Keywords:  semantic-buttons has-    |     Focuses:  ui, accessibility,
  patch has-screenshots commit       |  javascript
-------------------------------------+-------------------------------------
Changes (by afercia):

 * keywords:  semantic-buttons has-patch has-screenshots => semantic-buttons
     has-patch has-screenshots commit
 * owner:   => afercia
 * status:  new => assigned


Comment:

 Looking back at this, I think the link should be a button and also look
 like a button. There's no reason why it should look like a link, as it
 just toggles the visibility of the hidden updates container.

 [attachment:38674.diff] also adds an `aria-expanded` attribute, improves
 the distance between the buttons, and fixes the toggle animation "jump"
 due to the top margin on the animated div.

 Some testing would be nice.

 Screenshot:

 [[Image(https://cldup.com/Et-WD-fqb4.png)]]

--
Ticket URL: <https://core.trac.wordpress.org/ticket/38674#comment:9>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list