[wp-trac] [WordPress Trac] #44396: Inconsistent use of blogname and sitename in Privacy emails

[WordPress Trac]

#44396: Inconsistent use of blogname and sitename in Privacy emails
--------------------------+------------------------------
 Reporter:  desrosj       |       Owner:  (none)
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  Awaiting Review
Component:  Privacy       |     Version:  4.9.6
 Severity:  normal        |  Resolution:
 Keywords:  has-patch     |     Focuses:  multisite
--------------------------+------------------------------

Comment (by flixos90):

 I agree we should be consistent, my suggestion would be to use single-site
 terminology throughout. Even before the privacy-related changes in 4.9.6,
 there were inconsistencies, for example in
 `send_confirmation_on_profile_email()` which used the network name in one
 place, but the site name for another place, both affecting the same email.

 Since all of this so far does not really support a multisite-context yet,
 I think it makes sense to only use site scope at this point. Once we move
 forward with network-wide privacy control, we can enhance it as needed
 (for example there could be a parameter `$network_wide` for those emails,
 or similar).

 Last but not least, this context issue does not only affect the site name,
 but also the URL.

 In [attachment:44396.2.diff] I use `get_option( 'blogname' )` and
 `home_url()` throughout (instead of `get_site_option( 'site_name' )` and
 `network_home_url()` for the network). I also changed a variable name from
 `$blogname` to `$sitename` since we shouldn't be using the "blog"
 terminology any more, and that variable is being publicly exposed via a
 filter and its docs.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/44396#comment:2>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform