[wp-trac] [WordPress Trac] #44416: `compact()` will throw notice for undefined variables in PHP 7.3

[WordPress Trac]

#44416: `compact()` will throw notice for undefined variables in PHP 7.3
--------------------------+---------------------
 Reporter:  desrosj       |       Owner:  (none)
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  5.0
Component:  General       |     Version:
 Severity:  normal        |  Resolution:
 Keywords:  needs-patch   |     Focuses:
--------------------------+---------------------

Comment (by ayeshrajans):

 Re: `wp_insert_post()`: This function practically `extract()`'s the
 variables off the `$postarr` array, only to be converted into an array
 right before applying the hook. Perhaps we can keep a separate array to
 hold these variables and avoid the `compact()` call altogether.

 This function is a giant ~600 line function and I'm afraid to modify it
 this much without waking up cthulhu.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/44416#comment:4>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform