[wp-trac] [WordPress Trac] #36824: do_all_pings function queries all posts

[WordPress Trac]

#36824: do_all_pings function queries all posts
------------------------------+---------------------------
 Reporter:  spacedmonkey      |       Owner:  boonebgorges
     Type:  enhancement       |      Status:  reviewing
 Priority:  normal            |   Milestone:  4.9.7
Component:  Pings/Trackbacks  |     Version:  2.1
 Severity:  normal            |  Resolution:
 Keywords:  needs-patch       |     Focuses:  performance
------------------------------+---------------------------
Changes (by boonebgorges):

 * keywords:  has-patch => needs-patch


Comment:

 [attachment:36824.8.diff] fixes a `meta_key`/`meta_value` mismatch with
 `_encloseme`, and does some cleanup for PHPCS.

 The "Do trackbacks" section needs more work. `get_posts()` and `WP_Query`
 do not support a `to_ping` parameter. Above, there was some discussion
 about either adding it to `WP_Query`, or moving it to postmeta, but it
 looks like the current patch does neither of these things. The problem
 that originally prompted this ticket was that specific query, so we should
 be sure to address it one way or another.

 Regarding the change to `get_post_types_by_supports( 'trackbacks' )`, it
 feels like this might cause compatibility problems for plugins that may
 not be declaring support properly, but are still expecting trackbacks to
 be sent. Can someone walk through that scenario? It could be that it's
 only a concern if the plugin is manually setting `_pingme`, which happens
 in core only for the 'post' post type; see `wp_transition_post_status()`
 -> `'publish_post'` -> `_publish_post_hook()`. But it would be helpful to
 understand how likely it is that this'll be a breaking change for someone.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/36824#comment:38>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform