[wp-trac] [WordPress Trac] #44341: Replace _deprecated_function( 'add_filter' ) with apply_filters_deprecated()

[WordPress Trac]

#44341: Replace  _deprecated_function( 'add_filter' ) with
apply_filters_deprecated()
----------------------------------------------------+---------------------
 Reporter:  birgire                                 |       Owner:  (none)
     Type:  defect (bug)                            |      Status:  new
 Priority:  normal                                  |   Milestone:  4.9.7
Component:  Editor                                  |     Version:  4.3
 Severity:  normal                                  |  Resolution:
 Keywords:  good-first-bug has-patch needs-refresh  |     Focuses:  docs
----------------------------------------------------+---------------------
Changes (by desrosj):

 * keywords:  good-first-bug has-patch => good-first-bug has-patch needs-
     refresh
 * focuses:   => docs


Comment:

 @ianbelanger [attachment:44341.3.diff] looks good. A few minor changes:

 - Instead of putting the inline documentation before the `if()` statement,
 can there be a docblock above each `apply_filter_deprecated()` call?
 Putting it before each filter call would make it harder to miss.
 - There should be a `@param string $content` line in the docblocks
 describing the parameter.
 - The empy `* ` line after `@deprecated` should not be there.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/44341#comment:5>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform