[wp-trac] [WordPress Trac] #38323: Reconsider $object_subtype handling in `register_meta()`

[WordPress Trac]

#38323: Reconsider $object_subtype handling in `register_meta()`
-------------------------------------------------+-------------------------
 Reporter:  flixos90                             |       Owner:  kadamwhite
     Type:  enhancement                          |      Status:  reviewing
 Priority:  normal                               |   Milestone:  5.0
Component:  Options, Meta APIs                   |     Version:
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch needs-dev-note has-unit-   |     Focuses:  rest-api
  tests                                          |
-------------------------------------------------+-------------------------

Comment (by spacedmonkey):

 My view on this is the following.

 - Comment type is something I would really love to support, but I don't
 think that core currently supports it. There is no register comment type
 and no go way to workout type in the api. Until we have all that in place,
 I don't believe it should go in. However, I don't want this to block this
 ticket. I will open another ticket register comment types and how core can
 better support them.
 - I am not sure what the confusion with site meta. The meta type is blog
 and there is nothing we can do about that. As this function is most going
 to be used by core and develop interaction with it is likely to be with
 the get sub types filter, I don't see why we don't just put the case
 statement found in my patch.
 - I have updated on my patch for #44238 with
 [https://core.trac.wordpress.org/attachment/ticket/44238/44238.2.diff
 44238.2.diff]. This requires this patch to be in for it work, so I was
 unable to test it. But this patch alone is already 10kb of code. I think
 we should do it as patch, just for the sake of cleaness of commit and
 ablity to revert if something is wrong with protected meta.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/38323#comment:82>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform