[wp-trac] [WordPress Trac] #44379: GDPR filters should provide either $request or $request_id
WordPress Trac
noreply at wordpress.org
Mon Jun 18 20:08:52 UTC 2018
#44379: GDPR filters should provide either $request or $request_id
-----------------------------+------------------------------
Reporter: garrett-eclipse | Owner: (none)
Type: defect (bug) | Status: new
Priority: normal | Milestone: Awaiting Review
Component: Privacy | Version: 4.9.6
Severity: normal | Resolution:
Keywords: has-patch | Focuses:
-----------------------------+------------------------------
Changes (by desrosj):
* keywords: reporter-feedback => has-patch
* type: enhancement => defect (bug)
Comment:
Replying to [comment:5 garrett-eclipse]:
> I assume you're speaking on the mention of $request in the docblocks
like here;
>
https://github.com/WordPress/WordPress/blob/3ee58b55b14683af4c568bce1845c37408c88fbb
/wp-includes/user.php#L3379
Ah, yes. I see not that the request is not included. We should definitely
add this. I am changing this to a bug because the documentation is
inaccurate.
I also discovered it was difficult to replace the login URL working on
#44353, which I detailed in [ticket:44353:comment:6]. TL;DR: replacing
`site_url( 'wp-login.php' )` with `wp_login_url()` will allow plugins to
change the login URL without having to rebuild the confirm request URL.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/44379#comment:8>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list