[wp-trac] [WordPress Trac] #37110: Update to jQuery 3.*

[WordPress Trac]

#37110: Update to jQuery 3.*
-------------------------------------------------+-------------------------
 Reporter:  jorbin                               |       Owner:  (none)
     Type:  task (blessed)                       |      Status:  new
 Priority:  normal                               |   Milestone:  Future
                                                 |  Release
Component:  External Libraries                   |     Version:
 Severity:  critical                             |  Resolution:
 Keywords:  early has-patch needs-testing        |     Focuses:  javascript
  needs-dev-note needs-screenshots needs-        |
  refresh                                        |
-------------------------------------------------+-------------------------

Comment (by adamsilverstein):

 [attachment:37110.10.diff] includes only the upgrade on jquery and jquery
 migrate. after installing this patch (and running npm install && npm
 build), the only notable failure is the customizer menus section, which
 fails to properly load the 'add new' panel.

 ### Steps to reproduce

 * open customizer->menus->add new
 * note that the panel opens but is blank, the fields to add the new menu
 are missing

 other sections of the customizer work fine, adding menus on the regular
 screen works fine. other customizer sections work fine.  I do see some
 qunit test failing as well: https://travis-ci.org/adamsilverstein
 /wordpress-develop-fork/jobs/393334653

 i have spent many hours trying to track down what is failing to initialize
 but have yet to discover the underlying cause. given jquery migrate, i
 would have expected warnings but no errors/failures.  I do see many
 migrate warnings and have handled these in another branch, but none of
 these changes fixed the menus issue.

 My hunch is that the failure is due to changes in the way jQuery
 implements Promises and the ready event, although there are numerous
 breaking changes I have searched thru the codebase for usagees without any
 success: https://jquery.com/upgrade-guide/3.0/#breaking-change-document-
 ready-handlers-are-now-asynchronous

 @westonruter when you have a chance, can you test this patch out and see
 if anything pops out as a possible cause for the issue? Thanks in advance!

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/37110#comment:47>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform