[wp-trac] [WordPress Trac] #38323: Reconsider $object_subtype handling in `register_meta()`

WordPress Trac noreply at wordpress.org
Sun Jun 17 13:37:05 UTC 2018


#38323: Reconsider $object_subtype handling in `register_meta()`
-------------------------------------------------+-------------------------
 Reporter:  flixos90                             |       Owner:  kadamwhite
     Type:  enhancement                          |      Status:  reviewing
 Priority:  normal                               |   Milestone:  5.0
Component:  Options, Meta APIs                   |     Version:
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch needs-dev-note has-unit-   |     Focuses:  rest-api
  tests                                          |
-------------------------------------------------+-------------------------

Comment (by flixos90):

 [attachment:38323.15.diff] removes those changes that were made after
 [attachment:38323.12.diff] and were actually part of separate ticket
 efforts. It also reinstates comment subtypes for now - whether it should
 remain that way is subject to discussion in the next REST API meeting.

 It also fixes the object ID being correctly passed to the
 `get_post_type()` call in `get_object_subtype()`, as discovered by
 @spacedmonkey previously.

 Except the comment type discussion, this is ready. After we have
 determined whether we need comment subtype support or not, let's implement
 that and all give the related tests a final run. When those pass, we can
 ship it.

 Afterwards, we can focus on follow-up improvements, such as #43941, #44238
 and #44387.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/38323#comment:78>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list