[wp-trac] [WordPress Trac] #38323: Reconsider $object_subtype handling in `register_meta()`

WordPress Trac noreply at wordpress.org
Sun Jun 17 13:14:50 UTC 2018


#38323: Reconsider $object_subtype handling in `register_meta()`
-------------------------------------------------+-------------------------
 Reporter:  flixos90                             |       Owner:  kadamwhite
     Type:  enhancement                          |      Status:  reviewing
 Priority:  normal                               |   Milestone:  5.0
Component:  Options, Meta APIs                   |     Version:
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch needs-dev-note has-unit-   |     Focuses:  rest-api
  tests                                          |
-------------------------------------------------+-------------------------

Comment (by flixos90):

 Replying to [comment:75 spacedmonkey]:
 > - Added blog to `get_object_subtype` as site meta is now in core.

 As discussed before, this should happen in a separate follow-up ticket. It
 needs further thought in terms of how to handle the naming blog vs site,
 and this is a separate issue from general subtype handling, which is the
 focus of this ticket.

 > - Added new sub_type param to `is_protected_meta` See #44238 for
 background.

 These changes should happen in #44238, not in here.

 > - Remove comment type, as the comment rest endpoint controller doesn't
 support passing comment type as this time.

 At WCEU we decided to use comment types. I'm not sure why you removed them
 again, we didn't have any discussion in that regard. If you have concerns
 about comment subtypes, please let's discuss this in the REST API meeting
 this week. cc @kadamwhite

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/38323#comment:77>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list