[wp-trac] [WordPress Trac] #44314: `user_confirmed_action_email_content` filter run on two different strings

[WordPress Trac]

#44314: `user_confirmed_action_email_content` filter run on two different strings
--------------------------+---------------------
 Reporter:  desrosj       |       Owner:  (none)
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  4.9.7
Component:  Privacy       |     Version:  4.9.6
 Severity:  normal        |  Resolution:
 Keywords:  has-patch     |     Focuses:
--------------------------+---------------------

Comment (by garrett-eclipse):

 This looks great @desrosj

 The only edge case I wonder about as you confirmed that no plugins use
 that filter is any users who've custom coded using that filter and expect
 their fulfill email to update. Should we rename both instances so they're
 new and then with the original string setup a doing it wrong filter that
 indicates they should use one of either the others so as to avoid
 customizations that some users have done and expect it on the fulfill or
 both and now it's not doing it there. I'm probably overthinking but just
 wanted to put that out there.

 Cheers

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/44314#comment:2>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform