[wp-trac] [WordPress Trac] #43749: Update zxcvbn to 4.4.2

WordPress Trac noreply at wordpress.org
Fri Jun 15 19:39:23 UTC 2018


#43749: Update zxcvbn to 4.4.2
-------------------------------------------------+-------------------------
 Reporter:  desrosj                              |       Owner:  (none)
     Type:  enhancement                          |      Status:  new
 Priority:  normal                               |   Milestone:  Future
                                                 |  Release
Component:  External Libraries                   |     Version:
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch needs-refresh needs-       |     Focuses:  javascript
  testing                                        |
-------------------------------------------------+-------------------------
Changes (by desrosj):

 * keywords:  has-patch needs-refresh => has-patch needs-refresh needs-
               testing


Comment:

 In [attachment:43749.2.diff]:

 - Add the `grunt-rot13` and `zxcvbn` NPM libraries.
 - Configure the zxcvbn library to copy from its `node_module` folder to
 the correct `js` folder on `build`.
 - Set up initial `rot13` settings.

 Remaining tasks:
 - The `grunt rot13` task is currently ciphering the entire file. This
 needs to be updated so only the dictionary part of the file is ciphered.

 Also of note, the zxcvbn library has always been in core as
 `zxcvbn.min.js`, but is not actually minimized. Minimizing the file,
 though only results in a 2KB difference, though (820KB compared to 822KB).

 The NPM package also does not include a minimized version of the library.
 The file is copied from the package to the `js` without `.min` and is now
 minified via the `uglify:dynamic` task. If including the unminified
 version of the script is not desired, the unminified file should be
 removed after `uglify` runs.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/43749#comment:7>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list