[wp-trac] [WordPress Trac] #44371: Make sure all JS globals are explicitly assigned to the window.
WordPress Trac
noreply at wordpress.org
Thu Jun 14 16:44:23 UTC 2018
#44371: Make sure all JS globals are explicitly assigned to the window.
--------------------------+-----------------------------
Reporter: omarreiss | Owner: (none)
Type: defect (bug) | Status: new
Priority: normal | Milestone: Awaiting Review
Component: General | Version:
Severity: normal | Keywords:
Focuses: javascript |
--------------------------+-----------------------------
Currently there are a lot of variables in the JavaScript that are being
defined in the global scope without being explicitly assigned to the
`window`. When we start using Webpack to build all the JavaScript, the
code will get encapsulated in an anonymous function and those implicit
globals could get assigned to a different scope. To make sure that doesn't
happen, I've created a patch to make sure all globals are explicitly
assigned to the `window`.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/44371>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list